From 0378b2dc7d546ce3707ab245073221b9e1128a82 Mon Sep 17 00:00:00 2001 From: erik Date: Tue, 19 Dec 2023 10:55:30 +0100 Subject: [PATCH] Add questions for review discussion --- models/forgefed/actor.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/models/forgefed/actor.go b/models/forgefed/actor.go index 7a9c00ec40..12aa6358d1 100644 --- a/models/forgefed/actor.go +++ b/models/forgefed/actor.go @@ -36,7 +36,7 @@ func NewPersonId(uri string, source string) (PersonId, error) { // return PersonId{}, fmt.Errorf("uri %s is not a valid external url", uri) //} - validatedUri, _ := url.Parse(uri) + validatedUri, _ := url.Parse(uri) // ToDo: Why no err treatment at this place? pathWithActorID := strings.Split(validatedUri.Path, "/") if containsEmptyString(pathWithActorID) { pathWithActorID = removeEmptyStrings(pathWithActorID) @@ -66,7 +66,7 @@ func NewRepositoryId(uri string, source string) (RepositoryId, error) { return RepositoryId{}, fmt.Errorf("uri %s is not a valid repo url on this host %s", uri, setting.AppURL+"api") } - validatedUri, _ := url.Parse(uri) + validatedUri, _ := url.Parse(uri) // ToDo: Why no err treatment at this place? pathWithActorID := strings.Split(validatedUri.Path, "/") if containsEmptyString(pathWithActorID) { pathWithActorID = removeEmptyStrings(pathWithActorID)