diff --git a/modules/git/grep.go b/modules/git/grep.go index 93423a85ce..5572bd994f 100644 --- a/modules/git/grep.go +++ b/modules/git/grep.go @@ -36,6 +36,12 @@ type GrepOptions struct { PathSpec []setting.Glob } +func (opts *GrepOptions) ensureDefaults() { + opts.RefName = cmp.Or(opts.RefName, "HEAD") + opts.MaxResultLimit = cmp.Or(opts.MaxResultLimit, 50) + opts.MatchesPerFile = cmp.Or(opts.MatchesPerFile, 20) +} + func hasPrefixFold(s, t string) bool { if len(s) < len(t) { return false @@ -53,6 +59,8 @@ func GrepSearch(ctx context.Context, repo *Repository, search string, opts GrepO _ = stdoutWriter.Close() }() + opts.ensureDefaults() + /* The output is like this ("^@" means \x00; the first number denotes the line, the second number denotes the column of the first match in line): @@ -69,7 +77,6 @@ func GrepSearch(ctx context.Context, repo *Repository, search string, opts GrepO "-I", "--null", "--break", "--heading", "--column", "--fixed-strings", "--line-number", "--ignore-case", "--full-name") cmd.AddOptionValues("--context", fmt.Sprint(opts.ContextLineNumber)) - opts.MatchesPerFile = cmp.Or(opts.MatchesPerFile, 20) cmd.AddOptionValues("--max-count", fmt.Sprint(opts.MatchesPerFile)) words := []string{search} if opts.IsFuzzy { @@ -90,9 +97,8 @@ func GrepSearch(ctx context.Context, repo *Repository, search string, opts GrepO for _, expr := range setting.Indexer.ExcludePatterns { files = append(files, ":^"+expr.Pattern()) } - cmd.AddDynamicArguments(cmp.Or(opts.RefName, "HEAD")).AddDashesAndList(files...) + cmd.AddDynamicArguments(opts.RefName).AddDashesAndList(files...) - opts.MaxResultLimit = cmp.Or(opts.MaxResultLimit, 50) stderr := bytes.Buffer{} err = cmd.Run(&RunOpts{ Timeout: time.Duration(setting.Git.Timeout.Grep) * time.Second,