From 9212fb1633550bade7915eec98cf9c832ce582f9 Mon Sep 17 00:00:00 2001
From: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date: Tue, 2 Apr 2024 09:03:49 +0200
Subject: [PATCH] feedback from discussion

---
 .../adr-how-to-trigger-activities.md          | 30 +++++++++++++++++--
 1 file changed, 28 insertions(+), 2 deletions(-)

diff --git a/docs/unsure-where-to-put/adr-how-to-trigger-activities.md b/docs/unsure-where-to-put/adr-how-to-trigger-activities.md
index 906ba6498a..a70033a0e5 100644
--- a/docs/unsure-where-to-put/adr-how-to-trigger-activities.md
+++ b/docs/unsure-where-to-put/adr-how-to-trigger-activities.md
@@ -1,5 +1,18 @@
 # How to Trigger Activities
 
+- [How to Trigger Activities](#how-to-trigger-activities)
+  - [Status](#status)
+  - [Context](#context)
+  - [Decision](#decision)
+  - [Choices](#choices)
+    - [1. Transient Federation without Constraints](#1-transient-federation-without-constraints)
+      - [Problem - Circularity And Inconsistency](#problem---circularity-and-inconsistency)
+    - [2. Direct Federation only](#2-direct-federation-only)
+      - [Discussion for option 2.](#discussion-for-option-2)
+    - [3. Transient Federation and Remember Processed](#3-transient-federation-and-remember-processed)
+  - [See also](#see-also)
+
+
 ## Status
 
 Proposal
@@ -23,7 +36,7 @@ flowchart TD
 
 ## Choices
 
-### 1. Transient Federation
+### 1. Transient Federation without Constraints
 
 In this case the star federation process would look like:
 
@@ -54,7 +67,7 @@ flowchart TD
    Thus, the repo on instance A gets another star by this user and sends Like-Activity to the repo on instance C.
 7. The circular distribution of Like-Activities continues, since the actor is always the local FederatedUser of the sending instance.
 
-### 2. Direct Federation
+### 2. Direct Federation only
 
 ```mermaid
 flowchart TD
@@ -72,5 +85,18 @@ In this case the star federation process would look like:
     1. Instance creates FederatedUser and stars the repository.
     2. No further star federation to federated repos is triggered.
 
+#### Discussion for option 2.
+
+1. pro
+   1. Prevent circular communication
+   2. Clear semantic also in case of "Who should authorize a digital signature"
+
+### 3. Transient Federation and Remember Processed
+
+In this case the star federation process would look like:
+
+1. Repo on an instance receives a star (regardless of whether via UI or federation)
+2. If this activity was not operated already in this instance, federate star to all repos that are set as federated repositories.
+
 ## See also