18 commits

Author	SHA1	Message	Date
Earl Warren	0c70e11df8	Merge pull request 'git-grep: refactor defaults' (#4964) from yoctozepto/git-grep-refactor-defaults into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4964 Reviewed-by: Shiny Nematoda <snematoda@noreply.codeberg.org>	2024-08-19 13:12:37 +00:00
Radosław Piliszek	f784260633	git-grep: refactor defaults ... One method to set them all... or something like that. The defaults for git-grep options were scattered over the run function body. This change refactors them into a separate method. The application of defaults is checked implicitly by existing tests and linters, and the new approach makes it very easy to inspect the desired defaults are set.	2024-08-19 14:28:01 +02:00
Earl Warren	fbb2252314	Merge pull request 'git-grep: fix for initial dashes in expressions' (#4967) from yoctozepto/git-grep-fix-words into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4967 Reviewed-by: Shiny Nematoda <snematoda@noreply.codeberg.org>	2024-08-17 07:07:40 +00:00
Otto	d26ad8dbe5	Merge pull request 'git-grep: set timeout to 2s by default and allow configuring it' (#4966) from yoctozepto/git-grep-timeout into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4966 Reviewed-by: Otto <otto@codeberg.org>	2024-08-15 12:15:16 +00:00
Radosław Piliszek	824dd6bc5d	git-grep: set timeout to 2s by default and allow configuring it ... We need to shorten the timeout to bound effectively for computation size. This protects against "too big" repos. This also protects to some extent against too long lines if kept to very low values (basically so that grep cannot run out of memory beforehand). Docs-PR: forgejo/docs#812	2024-08-14 07:55:05 +02:00
Radosław Piliszek	f4d86b4ab0	git-grep: fix for initial dashes in expressions ... There is no reason to reject initial dashes in git-grep expressions... other than the code not supporting it previously. A new method is introduced to relax the security checks.	2024-08-12 22:12:47 +02:00
Otto	4132b18e59	Merge pull request 'git-grep: ensure bounded default for MatchesPerFile' (#4928) from yoctozepto/forgejo:git-grep-limit-matches-per-file into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4928 Reviewed-by: Shiny Nematoda <snematoda@noreply.codeberg.org> Reviewed-by: Otto <otto@codeberg.org>	2024-08-12 14:37:43 +00:00
Radosław Piliszek	f4a7bf6d2a	git-grep: skip binary files ... It is a waste of resources to scan them looking for matches because they are never returned back - they appear as empty lines in the current format. Notably, even if they were returned, it is unlikely that matching in binary files makes sense when the goal is "code search".	2024-08-11 19:10:23 +02:00
Radosław Piliszek	2fbb51ceb2	git-grep: ensure bounded default for MatchesPerFile ... Analogously to how it happens for MaxResultLimit. The default of 20 is inspired by a well-known, commercial code hosting platform. Unbounded limits are risky because they expose Forgejo to a class of DoS attacks where queries are crafted to take advantage of missing bounds.	2024-08-11 14:59:46 +02:00
Radosław Piliszek	7dd7cc7ebc	git-grep: update comment ... It was outdated and missing detail.	2024-08-10 16:41:12 +02:00
Shiny Nematoda	06d2e90fa4	feat: highlighted code search results (#4749) ... closes #4534 <details> <summary>Screenshots</summary>  </details> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4749 Reviewed-by: 0ko <0ko@noreply.codeberg.org> Co-authored-by: Shiny Nematoda <snematoda.751k2@aleeas.com> Co-committed-by: Shiny Nematoda <snematoda.751k2@aleeas.com>	2024-08-06 05:57:25 +00:00
Shiny Nematoda	ec4f5495ba	feat: wiki search using git-grep ... + add release note	2024-05-20 13:48:50 +00:00
Shiny Nematoda	b6ca8abcfd	[FEAT] support searching non default branches/tags when using git-grep (#3654) ... resolves https://codeberg.org/forgejo/forgejo/pulls/3639#issuecomment-1806676 and https://codeberg.org/forgejo/forgejo/pulls/3513#issuecomment-1794990 Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3654 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Shiny Nematoda <snematoda.751k2@aleeas.com> Co-committed-by: Shiny Nematoda <snematoda.751k2@aleeas.com>	2024-05-14 15:41:03 +00:00
Gusted	668709a33f	[BUG] Handle bigger files in git grep ... - The parser of `git grep`'s output uses `bufio.Scanner`, which is a good choice overall, however it does have a limit that's usually not noticed, it will not read more than `64 * 1024` bytes at once which can be hit in practical scenarios. - Use `bufio.Reader` instead which doesn't have this limitation, but is a bit harder to work with as it's a more lower level primitive. - Adds unit test. - Resolves https://codeberg.org/forgejo/forgejo/issues/3149	2024-04-11 13:47:50 +02:00
Shiny Nematoda	baac15f316	[FEAT] Support Include/Exclude Filters for Grep (#3058) ... fixes `TestRepoSearch` failing occasionally Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3058 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Shiny Nematoda <snematoda.751k2@aleeas.com> Co-committed-by: Shiny Nematoda <snematoda.751k2@aleeas.com>	2024-04-06 13:25:39 +00:00
Shiny Nematoda	db7e6948a1	replace IfZero with cmp.Or	2024-03-28 11:58:26 +00:00
wxiaoguang	eb21829800	Fix git grep search limit, add test (#30071) ... Fix #30069	2024-03-28 07:48:35 +00:00
wxiaoguang	1e7a6483b8	Support repo code search without setting up an indexer (#29998) ... By using git's ability, end users (especially small instance users) do not need to enable the indexer, they could also benefit from the code searching feature. Fix #29996   --------- Co-authored-by: silverwind <me@silverwind.io>	2024-03-28 05:16:51 +00:00