Michael Kriese
bc259542b5
chore(renovate): fix renovate grouping
2024-07-26 14:07:39 +02:00
Earl Warren
904925ee4d
Merge pull request 'Update dependency tailwindcss to v3.4.7 (forgejo)' ( #4695 ) from renovate/forgejo-tailwindcss-3.x into forgejo
...
/ release (push) Waiting to run
testing / backend-checks (push) Waiting to run
testing / frontend-checks (push) Waiting to run
testing / test-unit (push) Blocked by required conditions
testing / test-remote-cacher (map[image:docker.io/valkey/valkey:7.2.5-alpine3.19 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:ghcr.io/microsoft/garnet-alpine:1.0.14 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:redis:7.2 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:registry.redict.io/redict:7.3.0-scratch port:6379]) (push) Blocked by required conditions
testing / test-mysql (push) Blocked by required conditions
testing / test-pgsql (push) Blocked by required conditions
testing / test-sqlite (push) Blocked by required conditions
testing / security-check (push) Blocked by required conditions
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4695
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-07-26 04:52:59 +00:00
Renovate Bot
c192e70b94
Update dependency tailwindcss to v3.4.7
2024-07-26 00:02:10 +00:00
Earl Warren
1f939a2a40
Merge pull request 'feat(release-notes-assistant): diff of the change in preview' ( #4693 ) from twenty-panda/forgejo:wip-rna into forgejo
...
/ release (push) Waiting to run
testing / security-check (push) Blocked by required conditions
testing / backend-checks (push) Waiting to run
testing / frontend-checks (push) Waiting to run
testing / test-unit (push) Blocked by required conditions
testing / test-remote-cacher (map[image:docker.io/valkey/valkey:7.2.5-alpine3.19 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:ghcr.io/microsoft/garnet-alpine:1.0.14 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:redis:7.2 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:registry.redict.io/redict:7.3.0-scratch port:6379]) (push) Blocked by required conditions
testing / test-mysql (push) Blocked by required conditions
testing / test-pgsql (push) Blocked by required conditions
testing / test-sqlite (push) Blocked by required conditions
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4693
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-25 20:51:16 +00:00
Earl Warren
90f80be3f0
Merge pull request 'Fix conversation template' ( #4691 ) from 0ko/forgejo:ui-roles-reviews into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4691
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-25 20:46:11 +00:00
Twenty Panda
b85ec067ca
feat(release-notes-assistant): diff of the change in preview
2024-07-25 22:32:14 +02:00
0ko
13cb4b3f2e
fix(ui): fix conversation template
2024-07-25 23:51:17 +05:00
Earl Warren
edf2cbe768
Merge pull request '[I18N] Remove unneeded translation' ( #4690 ) from gusted/forgejo-rm-unneeded-tr into forgejo
...
/ release (push) Waiting to run
testing / backend-checks (push) Waiting to run
testing / frontend-checks (push) Waiting to run
testing / test-unit (push) Blocked by required conditions
testing / test-remote-cacher (map[image:docker.io/valkey/valkey:7.2.5-alpine3.19 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:ghcr.io/microsoft/garnet-alpine:1.0.14 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:redis:7.2 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:registry.redict.io/redict:7.3.0-scratch port:6379]) (push) Blocked by required conditions
testing / test-mysql (push) Blocked by required conditions
testing / test-pgsql (push) Blocked by required conditions
testing / test-sqlite (push) Blocked by required conditions
testing / security-check (push) Blocked by required conditions
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4690
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-25 16:04:49 +00:00
Gusted
76759715d2
[I18N] Remove unneeded translation
...
- This key isn't used, I added this on accident (likely bad copy-paste).
- Regression of #4635
2024-07-25 17:04:23 +02:00
Earl Warren
c43bb32010
Merge pull request 'fix(api): issue state change is not idempotent' ( #4687 ) from earl-warren/forgejo:wip-issue-state-idempotency into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4687
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-07-25 14:20:34 +00:00
Earl Warren
e9e3b8c0f3
fix(api): issue state change is not idempotent
...
The PATCH if issue & pull request switched to use the service
functions instead. However, the service function changing the state is
not idempotent. Instead of doing nothing which changing from open to
open or close to close, it will fail with an error like:
Issue [2472] 0 was already closed
Regression of: 6a4bc0289dhttps://codeberg.org/forgejo/forgejo/issues/4686
2024-07-25 15:16:44 +02:00
Earl Warren
f8bc48f8df
Merge pull request 'Update dependency vue to v3.4.34 (forgejo)' ( #4678 ) from renovate/forgejo-patch-vue-monorepo into forgejo
...
/ release (push) Waiting to run
testing / backend-checks (push) Waiting to run
testing / frontend-checks (push) Waiting to run
testing / test-unit (push) Blocked by required conditions
testing / test-remote-cacher (map[image:docker.io/valkey/valkey:7.2.5-alpine3.19 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:ghcr.io/microsoft/garnet-alpine:1.0.14 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:redis:7.2 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:registry.redict.io/redict:7.3.0-scratch port:6379]) (push) Blocked by required conditions
testing / test-mysql (push) Blocked by required conditions
testing / test-pgsql (push) Blocked by required conditions
testing / test-sqlite (push) Blocked by required conditions
testing / security-check (push) Blocked by required conditions
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4678
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-07-25 08:50:10 +00:00
Earl Warren
8571f1d5d9
Merge pull request 'Update dependency monaco-editor to v0.50.0 (forgejo)' ( #4604 ) from renovate/forgejo-monaco-editor-0.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4604
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-07-25 08:10:30 +00:00
Earl Warren
0713451c28
Merge pull request 'Update dependency postcss to v8.4.40 (forgejo)' ( #4677 ) from renovate/forgejo-postcss-packages into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4677
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-07-25 08:10:20 +00:00
Renovate Bot
03c1b61573
Update dependency vue to v3.4.34
renovate / renovate (push) Has been cancelled
2024-07-25 08:04:49 +00:00
Earl Warren
875e6496c6
Merge pull request '[CHORE] Remove AGPL-1.0 as allowed license' ( #4673 ) from gusted/forgejo-rm-agpl into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4673
Reviewed-by: Beowulf <beowulf@noreply.codeberg.org>
2024-07-25 07:40:19 +00:00
Earl Warren
783fa3e108
Merge pull request 'fix(release-notes-assistant): remove extra newline on breaking bugs' ( #4683 ) from earl-warren/forgejo:wip-rna-preview into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4683
Reviewed-by: twenty-panda <twenty-panda@noreply.codeberg.org>
2024-07-25 07:32:51 +00:00
Earl Warren
4f7746427f
fix(release-notes-assistant): remove extra newline on breaking bugs
2024-07-25 08:26:03 +02:00
Robert Wolff
0a74c95b2a
fix(ui): use right placeholder string in milestones search ( #4628 )
...
This PR fixes a wrong placeholder for the search for milestones. I tested it locally (see attachments, below).
Before: https://codeberg.org/attachments/ba845ce1-1f20-4131-a74d-7220986a4acf
After: https://codeberg.org/attachments/0c4e32ee-b1a8-4472-837d-daa2a2a50121
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4628
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Co-authored-by: Robert Wolff <mahlzahn@posteo.de>
Co-committed-by: Robert Wolff <mahlzahn@posteo.de>
2024-07-25 03:33:44 +00:00
Gusted
56dbe3263f
Merge pull request '[CHORE] Don't bundle elkjs' ( #4670 ) from gusted/forgejo-elkjs into forgejo
...
/ release (push) Waiting to run
testing / backend-checks (push) Waiting to run
testing / frontend-checks (push) Waiting to run
testing / test-unit (push) Blocked by required conditions
testing / test-remote-cacher (map[image:docker.io/valkey/valkey:7.2.5-alpine3.19 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:ghcr.io/microsoft/garnet-alpine:1.0.14 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:redis:7.2 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:registry.redict.io/redict:7.3.0-scratch port:6379]) (push) Blocked by required conditions
testing / test-mysql (push) Blocked by required conditions
testing / test-pgsql (push) Blocked by required conditions
testing / test-sqlite (push) Blocked by required conditions
testing / security-check (push) Blocked by required conditions
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4670
Reviewed-by: Beowulf <beowulf@noreply.codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-25 00:15:35 +00:00
Renovate Bot
c23cac5073
Update dependency postcss to v8.4.40
2024-07-25 00:04:25 +00:00
Gusted
a6b4fb7729
[CHORE] Remove AGPL-1.0 as allowed license
...
- The last dependency using this license was removed in #4595 (thanks @Beowulf!).
2024-07-24 23:38:31 +02:00
Earl Warren
419c129ec7
Merge pull request 'Replace Gitea with Forgejo' ( #4660 ) from yonas/forgejo:yonas-patch-1 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4660
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-07-24 21:35:14 +00:00
Earl Warren
c75c6b392c
Merge pull request '[UI] Fix scoped-access-token' ( #4669 ) from gusted/forgejo-fix-regg into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4669
Reviewed-by: Beowulf <beowulf@noreply.codeberg.org>
2024-07-24 21:34:19 +00:00
Gusted
510cbe2c92
[CHORE] Don't bundle elkjs
...
- `elkjs` is a library that's imported by `mermaid`, although they have
seperated this package to it's own mermaid
package (https://github.com/mermaid-js/mermaid/pull/5654 ), the stable
version doesn't have this patch.
- `elkjs` is licensed under the EPL-2.0 license (copyleft), which isn't
compatible with GPL unless the license author explcitly allow this via a
so called "secondary license". At the end of the day it cannot be
released under a MIT or GPL license.
- Use webpack's `externals` option to avoid bundling `elkjs` and instead
leave it as a `require` code.
- This is a 'dirty' way to ensure elkjs isn't bundled and has to be
tested manually to ensure this for every release (via the
`webpack-bundle-analyzer` plugin). If someone tries to use the elkjs
render, it will result in a non-descriptive error being shown.
2024-07-24 23:28:59 +02:00
Gusted
aa5163d5c4
[UI] Fix scoped-access-token
...
- Regression of #4571
- Refactor to not use the component API of Vue. The root cause is still
unknown.
2024-07-24 21:48:51 +02:00
Earl Warren
b55136d561
Merge pull request 'fix(release-notes-assistant): do not trigger on open' ( #4665 ) from twenty-panda/forgejo:wip-rna-trigger into forgejo
...
/ release (push) Waiting to run
testing / test-remote-cacher (map[image:registry.redict.io/redict:7.3.0-scratch port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:redis:7.2 port:6379]) (push) Blocked by required conditions
testing / backend-checks (push) Waiting to run
testing / frontend-checks (push) Waiting to run
testing / test-unit (push) Blocked by required conditions
testing / test-remote-cacher (map[image:docker.io/valkey/valkey:7.2.5-alpine3.19 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:ghcr.io/microsoft/garnet-alpine:1.0.14 port:6379]) (push) Blocked by required conditions
testing / test-mysql (push) Blocked by required conditions
testing / test-pgsql (push) Blocked by required conditions
testing / test-sqlite (push) Blocked by required conditions
testing / security-check (push) Blocked by required conditions
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4665
2024-07-24 16:32:43 +00:00
Twenty Panda
e9a3306f6e
fix(release-notes-assistant): do not trigger on open
...
Forgejo sets a label and will notify this when opening the pull
request. Triggering when it opens will make two workflows for the same
SHA. Re-opening is a border case that is not needed.
2024-07-24 18:26:59 +02:00
Earl Warren
762f4b5408
Merge pull request 'fix(release-notes-assistant): ignore WIP prefixes' ( #4663 ) from earl-warren/forgejo:wip-rna-preview into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4663
Reviewed-by: twenty-panda <twenty-panda@noreply.codeberg.org>
2024-07-24 14:55:29 +00:00
Earl Warren
ba006b2eef
fix(release-notes-assistant): ignore WIP prefixes
2024-07-24 16:49:21 +02:00
yonas
9ad23f9ede
Replace Gitea with Forgejo
2024-07-24 14:17:23 +00:00
Earl Warren
479a98fd18
Merge pull request 'docs(release-notes): 8.0.0 - updates' ( #4657 ) from earl-warren/forgejo:wip-release-notes into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4657
Reviewed-by: twenty-panda <twenty-panda@noreply.codeberg.org>
2024-07-24 13:17:13 +00:00
Earl Warren
77c30ad85b
docs(release-notes): 8.0.0 - updates
2024-07-24 15:14:38 +02:00
Codeberg Translate
7699d85f3b
[I18N] Translations update from Weblate ( #4568 )
...
/ release (push) Waiting to run
testing / test-remote-cacher (map[image:redis:7.2 port:6379]) (push) Blocked by required conditions
testing / backend-checks (push) Waiting to run
testing / frontend-checks (push) Waiting to run
testing / test-unit (push) Blocked by required conditions
testing / test-remote-cacher (map[image:docker.io/valkey/valkey:7.2.5-alpine3.19 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:ghcr.io/microsoft/garnet-alpine:1.0.14 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:registry.redict.io/redict:7.3.0-scratch port:6379]) (push) Blocked by required conditions
testing / test-mysql (push) Blocked by required conditions
testing / test-pgsql (push) Blocked by required conditions
testing / test-sqlite (push) Blocked by required conditions
testing / security-check (push) Blocked by required conditions
Translations update from [Weblate](https://translate.codeberg.org ) for [Forgejo/forgejo](https://translate.codeberg.org/projects/forgejo/forgejo/ ).
Current translation status:
<!--start release-notes-assistant-->
## Draft release notes
<!--URL:https://codeberg.org/forgejo/forgejo-- >
- Localization
- [PR](https://codeberg.org/forgejo/forgejo/pulls/4568 )</a>: <!--number 4568 --><!--line 0 --><!--description W0kxOE5dIFRyYW5zbGF0aW9ucyB1cGRhdGUgZnJvbSBXZWJsYXRl-->[I18N] Translations update from Weblate<!--description-->
<!--end release-notes-assistant-->
Co-authored-by: earl-warren <earl-warren@users.noreply.translate.codeberg.org>
Co-authored-by: 0ko <0ko@users.noreply.translate.codeberg.org>
Co-authored-by: mahlzahn <mahlzahn@posteo.de>
Co-authored-by: Gusted <postmaster@gusted.xyz>
Co-authored-by: leana8959 <leana8959@users.noreply.translate.codeberg.org>
Co-authored-by: Fjuro <fjuro@alius.cz>
Co-authored-by: Wuzzy <Wuzzy@users.noreply.translate.codeberg.org>
Co-authored-by: meskobalazs <meskobalazs@users.noreply.translate.codeberg.org>
Co-authored-by: Bálint Gonda <balinteus@gmail.com>
Co-authored-by: Beowulf <Beowulf@users.noreply.translate.codeberg.org>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4568
Co-authored-by: Codeberg Translate <translate@noreply.codeberg.org>
Co-committed-by: Codeberg Translate <translate@noreply.codeberg.org>
2024-07-24 08:41:30 +00:00
Earl Warren
a0dbc3ae70
Merge pull request 'fix(release-notes-assistant): add the Localization category' ( #4655 ) from earl-warren/forgejo:wip-rna-preview into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4655
Reviewed-by: twenty-panda <twenty-panda@noreply.codeberg.org>
2024-07-24 07:18:41 +00:00
Earl Warren
bca3f857dc
Merge pull request 'Update dependency @vitejs/plugin-vue to v5.1.0 (forgejo)' ( #4653 ) from renovate/forgejo-vitejs-plugin-vue-5.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4653
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-07-24 05:20:30 +00:00
Earl Warren
54e364b7bc
fix(release-notes-assistant): add the Localization category
...
The Localization category groups translations updates towards the end
of the release notes.
2024-07-24 06:22:35 +02:00
Earl Warren
1a2c611c42
Merge pull request 'feat(release-notes-assistant): if no labels, fallback to prefix' ( #4651 ) from twenty-panda/forgejo:wip-rna into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4651
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-24 04:04:47 +00:00
Renovate Bot
1f4666c6cd
Update dependency @vitejs/plugin-vue to v5.1.0
2024-07-24 00:04:06 +00:00
Twenty Panda
7db4dfa768
fix(release-notes-assistant): upgrade to convert \r\n
...
When a milestone or a pull request body is \r\n separated, they are
converted to newlines. Otherwise it makes it more difficult to compare
lines.
2024-07-24 00:07:53 +02:00
Twenty Panda
db64236f85
feat(release-notes-assistant): if no labels, fallback to prefix
...
* support feat: fix: feat!: fix! conventional commits prefixes
* add unit tests
2024-07-24 00:07:29 +02:00
Earl Warren
14d079a1eb
Merge pull request '[FEAT] Enable INVALIDATE_REFRESH_TOKENS' ( #4633 ) from gusted/sec-oauth into forgejo
...
/ release (push) Waiting to run
testing / backend-checks (push) Waiting to run
testing / frontend-checks (push) Waiting to run
testing / test-unit (push) Blocked by required conditions
testing / test-remote-cacher (map[image:docker.io/valkey/valkey:7.2.5-alpine3.19 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:ghcr.io/microsoft/garnet-alpine:1.0.14 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:redis:7.2 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:registry.redict.io/redict:7.3.0-scratch port:6379]) (push) Blocked by required conditions
testing / test-mysql (push) Blocked by required conditions
testing / test-pgsql (push) Blocked by required conditions
testing / test-sqlite (push) Blocked by required conditions
testing / security-check (push) Blocked by required conditions
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4633
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-23 20:45:22 +00:00
Earl Warren
5a922ca983
Merge pull request 'Release note for #4595 ' ( #4634 ) from beowulf/release-notes/4595.md into forgejo
...
/ release (push) Waiting to run
testing / test-sqlite (push) Blocked by required conditions
testing / security-check (push) Blocked by required conditions
testing / backend-checks (push) Waiting to run
testing / frontend-checks (push) Waiting to run
testing / test-unit (push) Blocked by required conditions
testing / test-remote-cacher (map[image:docker.io/valkey/valkey:7.2.5-alpine3.19 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:ghcr.io/microsoft/garnet-alpine:1.0.14 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:redis:7.2 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:registry.redict.io/redict:7.3.0-scratch port:6379]) (push) Blocked by required conditions
testing / test-mysql (push) Blocked by required conditions
testing / test-pgsql (push) Blocked by required conditions
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4634
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-23 18:18:30 +00:00
Gusted
ea1a0ebbc3
Merge pull request '[SECURITY] Notify users about account security changes' ( #4635 ) from gusted/sec-notify into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4635
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-23 17:50:59 +00:00
Beowulf
44156b6006
added release notes for pr 4595
...
(removed support for the APA citation format)
2024-07-23 18:47:42 +02:00
Gusted
4383da91bd
[SECURITY] Notify users about account security changes
...
- Currently if the password, primary mail, TOTP or security keys are
changed, no notification is made of that and makes compromising an
account a bit easier as it's essentially undetectable until the original
person tries to log in. Although other changes should be made as
well (re-authing before allowing a password change), this should go a
long way of improving the account security in Forgejo.
- Adds a mail notification for password and primary mail changes. For
the primary mail change, a mail notification is sent to the old primary
mail.
- Add a mail notification when TOTP or a security keys is removed, if no
other 2FA method is configured the mail will also contain that 2FA is
no longer needed to log into their account.
- `MakeEmailAddressPrimary` is refactored to the user service package,
as it now involves calling the mailer service.
- Unit tests added.
- Integration tests added.
2024-07-23 18:31:47 +02:00
Earl Warren
ded237ee77
Merge pull request '[gitea] week 2024-30 cherry pick (gitea/main -> forgejo)' ( #4607 ) from algernon/wcp/2024-30 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4607
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-23 16:01:28 +00:00
banaanihillo
522e652e8d
[accessibility] Add keyboard support for test actions ( #4490 )
...
- Existing gear icon keyup handler fixed:
moved the handler onto its descendant button,
to prevent it from incorrectly firing on the check-box elements
- Check-box elements: keyup elements for space and enter added,
as well as tabindex elements to make them able to gain focus
<!--
Before submitting a PR, please read the contributing guidelines:
https://codeberg.org/forgejo/forgejo/src/branch/forgejo/CONTRIBUTING.md
-->
To test the check boxes:
- Set up an action, and visit the action's job page
- Navigate onto the job container (via Tab et al.)
- Use the gear icon with Space or Enter
- Tick the check-box items with Space or Enter
To test the elements beside the chevron icons:
- Navigate onto the element via Tab et al.
- Open/close them via Space or Enter
I have not had a chance to test the latter fix (https://codeberg.org/forgejo/forgejo/issues/4476#issuecomment-2092312 ) myself yet; feel free to reject this one in case the latter fix does not work as it should, and I will break this up into two separate pull requests.
<!--start release-notes-assistant-->
## Draft release notes
<!--URL:https://codeberg.org/forgejo/forgejo-- >
- User Interface bug fixes
- [PR](https://codeberg.org/forgejo/forgejo/pulls/4490 )</a>: <!--number 4490 --><!--line 0 --><!--description W2FjY2Vzc2liaWxpdHldIEFkZCBrZXlib2FyZCBzdXBwb3J0IGZvciB0ZXN0IGFjdGlvbnM=-->[accessibility] Add keyboard support for test actions<!--description-->
<!--end release-notes-assistant-->
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4490
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: banaanihillo <banaanihillo@noreply.codeberg.org>
Co-committed-by: banaanihillo <banaanihillo@noreply.codeberg.org>
2024-07-23 15:37:19 +00:00
Earl Warren
dd9abfcc09
Merge pull request 'fix(release-notes-assistant): upgrade to always insert a newline' ( #4646 ) from twenty-panda/forgejo:wip-rna into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4646
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-23 13:20:18 +00:00
Gusted
3ba64bd038
Merge pull request 'Reserve the devtest username' ( #4638 ) from ikuyo/forgejo:reserve-devtest into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4638
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-07-23 12:59:16 +00:00
