mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-16 06:46:16 +01:00
138942c09e
- Go's deadcode eliminator is quite simple, if you put a public function in a package `aa/bb` that is used only by tests, it would still be built if package `aa/bb` was imported. This means that if such functions use libraries relevant only to tests that those libraries would still be be built and increase the binary size of a Go binary. - This is also the case with Forgejo, `models/migrations/base/tests.go` contained functions exclusively used by tests which (skipping some steps here) imports https://github.com/ClickHouse/clickhouse-go, which is 2MiB. The `code.gitea.io/gitea/models/migrations/base` package is imported by `cmd/doctor` and thus the code of the clickhouse library is also built and included in the Forgejo binary, although entirely unused and not reachable. - This patch moves the test-related functions to their own package, so Go's deadcode eliminator knows not to build the test-related functions and thus reduces the size of the Forgejo binary. - It is not possible to move this to a `_test.go` file because Go does not allow importing functions from such files, so any test helper function must be in a non-test package and file. - Reduction of size (built with `TAGS="sqlite sqlite_unlock_notify" make build`): - Before: 95912040 bytes (92M) - After: 92306888 bytes (89M) |
||
|---|---|---|
| .. | ||
| base | ||
| fixtures | ||
| test | ||
| v1_6 | ||
| v1_7 | ||
| v1_8 | ||
| v1_9 | ||
| v1_10 | ||
| v1_11 | ||
| v1_12 | ||
| v1_13 | ||
| v1_14 | ||
| v1_15 | ||
| v1_16 | ||
| v1_17 | ||
| v1_18 | ||
| v1_19 | ||
| v1_20 | ||
| v1_21 | ||
| v1_22 | ||
| v1_23 | ||
| migrations.go | ||