mirror/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-01 05:36:19 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 9
forgejo/options
History
Zettat123 9a83aa28a3
Get rules by id when editing branch protection rule (#22932) 
When users rename an existing branch protection rule, a new rule with
the new name will be created and the old rule will still exist.

![image](https://user-images.githubusercontent.com/15528715/219276442-d3c001ad-e693-44ec-9ad2-b33f2666b49b.png)

---

![image](https://user-images.githubusercontent.com/15528715/219276478-547c3b93-b3f1-4292-a1ef-c1b7747fe1bb.png)

The reason is that the `SettingsProtectedBranchPost` function only get
branch protection rule by name before updating or creating a rule. When
the rule name changes, the function cannot find the existing rule so it
will create a new rule rather than update the existing rule. To fix the
bug, the function should get rule by id first.

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-02-20 19:30:41 +08:00
..
gitignore [skip ci] Updated licenses and gitignores 2022-12-25 00:19:36 +00:00
label Add label descriptions (#3662) 2018-03-13 10:03:55 +08:00
license [skip ci] Updated licenses and gitignores 2023-01-01 00:19:35 +00:00
locale Get rules by id when editing branch protection rule (#22932) 2023-02-20 19:30:41 +08:00
readme Bindata is optional and over-writable on restart (#354) 2016-12-22 19:12:23 +01:00