mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-15 14:36:18 +01:00
138942c09e
- Go's deadcode eliminator is quite simple, if you put a public function in a package `aa/bb` that is used only by tests, it would still be built if package `aa/bb` was imported. This means that if such functions use libraries relevant only to tests that those libraries would still be be built and increase the binary size of a Go binary. - This is also the case with Forgejo, `models/migrations/base/tests.go` contained functions exclusively used by tests which (skipping some steps here) imports https://github.com/ClickHouse/clickhouse-go, which is 2MiB. The `code.gitea.io/gitea/models/migrations/base` package is imported by `cmd/doctor` and thus the code of the clickhouse library is also built and included in the Forgejo binary, although entirely unused and not reachable. - This patch moves the test-related functions to their own package, so Go's deadcode eliminator knows not to build the test-related functions and thus reduces the size of the Forgejo binary. - It is not possible to move this to a `_test.go` file because Go does not allow importing functions from such files, so any test helper function must be in a non-test package and file. - Reduction of size (built with `TAGS="sqlite sqlite_unlock_notify" make build`): - Before: 95912040 bytes (92M) - After: 92306888 bytes (89M)
82 lines
2.1 KiB
Go
82 lines
2.1 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package v1_16 //nolint
|
|
|
|
import (
|
|
"testing"
|
|
|
|
migration_tests "code.gitea.io/gitea/models/migrations/test"
|
|
"code.gitea.io/gitea/modules/json"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
// LoginSource represents an external way for authorizing users.
|
|
type LoginSourceOriginalV189 struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
Type int
|
|
IsActived bool `xorm:"INDEX NOT NULL DEFAULT false"`
|
|
Cfg string `xorm:"TEXT"`
|
|
Expected string `xorm:"TEXT"`
|
|
}
|
|
|
|
func (ls *LoginSourceOriginalV189) TableName() string {
|
|
return "login_source"
|
|
}
|
|
|
|
func Test_UnwrapLDAPSourceCfg(t *testing.T) {
|
|
// Prepare and load the testing database
|
|
x, deferable := migration_tests.PrepareTestEnv(t, 0, new(LoginSourceOriginalV189))
|
|
if x == nil || t.Failed() {
|
|
defer deferable()
|
|
return
|
|
}
|
|
defer deferable()
|
|
|
|
// LoginSource represents an external way for authorizing users.
|
|
type LoginSource struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
Type int
|
|
IsActive bool `xorm:"INDEX NOT NULL DEFAULT false"`
|
|
Cfg string `xorm:"TEXT"`
|
|
Expected string `xorm:"TEXT"`
|
|
}
|
|
|
|
// Run the migration
|
|
if err := UnwrapLDAPSourceCfg(x); err != nil {
|
|
assert.NoError(t, err)
|
|
return
|
|
}
|
|
|
|
const batchSize = 100
|
|
for start := 0; ; start += batchSize {
|
|
sources := make([]*LoginSource, 0, batchSize)
|
|
if err := x.Table("login_source").Limit(batchSize, start).Find(&sources); err != nil {
|
|
assert.NoError(t, err)
|
|
return
|
|
}
|
|
|
|
if len(sources) == 0 {
|
|
break
|
|
}
|
|
|
|
for _, source := range sources {
|
|
converted := map[string]any{}
|
|
expected := map[string]any{}
|
|
|
|
if err := json.Unmarshal([]byte(source.Cfg), &converted); err != nil {
|
|
assert.NoError(t, err)
|
|
return
|
|
}
|
|
|
|
if err := json.Unmarshal([]byte(source.Expected), &expected); err != nil {
|
|
assert.NoError(t, err)
|
|
return
|
|
}
|
|
|
|
assert.EqualValues(t, expected, converted, "UnwrapLDAPSourceCfg failed for %d", source.ID)
|
|
assert.EqualValues(t, source.ID%2 == 0, source.IsActive, "UnwrapLDAPSourceCfg failed for %d", source.ID)
|
|
}
|
|
}
|
|
}
|