mirror/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-01 13:44:06 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 5
forgejo/options
History
yp05327 b693611b35
Don't show new pr button when page is not compare pull (#26431) 
Before:

![image](https://github.com/go-gitea/gitea/assets/18380374/ba69252f-3582-414a-9d62-b2b78d7035dd)
After:

![image](https://github.com/go-gitea/gitea/assets/18380374/71b8587c-b96e-48fb-b3e5-1a2a8b5d06fa)
(TestOrg:test is a tag not branch)

Problem:
In the template, we will not add `compare pull` class when
`PageIsComparePull` is false.

a370efc13f/templates/repo/diff/compare.tmpl (L2)
But in the js, we are using `.repository.compare.pull` to find the
button:

a370efc13f/web_src/js/features/repo-legacy.js (L552-L563)
So, if `PageIsComparePull` is false, the `New Pull Request` button will
be there, but has no response when we click it.
2024-01-21 15:13:00 +00:00
..
gitignore [skip ci] Updated licenses and gitignores 2022-12-25 00:19:36 +00:00
label Add loading yaml label template files (#22976) 2023-03-02 01:44:23 +02:00
license [skip ci] Updated licenses and gitignores 2024-01-08 00:26:06 +00:00
locale Don't show new pr button when page is not compare pull (#26431) 2024-01-21 15:13:00 +00:00
readme Bindata is optional and over-writable on restart (#354) 2016-12-22 19:12:23 +01:00