mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-10 12:15:43 +01:00
bbffcc3aec
There are multiple places where Gitea does not properly escape URLs that it is building and there are multiple places where it builds urls when there is already a simpler function available to use this.
This is an extensive PR attempting to fix these issues.
1. The first commit in this PR looks through all href, src and links in the Gitea codebase and has attempted to catch all the places where there is potentially incomplete escaping.
2. Whilst doing this we will prefer to use functions that create URLs over recreating them by hand.
3. All uses of strings should be directly escaped - even if they are not currently expected to contain escaping characters. The main benefit to doing this will be that we can consider relaxing the constraints on user names and reponames in future.
4. The next commit looks at escaping in the wiki and re-considers the urls that are used there. Using the improved escaping here wiki files containing '/'. (This implementation will currently still place all of the wiki files the root directory of the repo but this would not be difficult to change.)
5. The title generation in feeds is now properly escaped.
6. EscapePound is no longer needed - urls should be PathEscaped / QueryEscaped as necessary but then re-escaped with Escape when creating html with locales Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
198 lines
8.7 KiB
Handlebars
198 lines
8.7 KiB
Handlebars
{{template "base/head" .}}
|
|
<div class="page-content repository release">
|
|
{{template "repo/header" .}}
|
|
<div class="ui container">
|
|
{{template "base/alert" .}}
|
|
<h2 class="ui compact small menu header">
|
|
{{if .Permission.CanRead $.UnitTypeReleases}}
|
|
<a class="{{if (not .PageIsTagList)}}active{{end}} item" href="{{.RepoLink}}/releases">{{.i18n.Tr "repo.release.releases"}}</a>
|
|
{{end}}
|
|
{{if .Permission.CanRead $.UnitTypeCode}}
|
|
<a class="{{if .PageIsTagList}}active{{end}} item" href="{{.RepoLink}}/tags">{{.i18n.Tr "repo.release.tags"}}</a>
|
|
{{end}}
|
|
</h2>
|
|
{{if (and .CanCreateRelease (not .PageIsTagList))}}
|
|
<a class="ui right small green button" href="{{$.RepoLink}}/releases/new">
|
|
{{.i18n.Tr "repo.release.new_release"}}
|
|
</a>
|
|
{{end}}
|
|
{{if .PageIsTagList}}
|
|
<div class="ui divider"></div>
|
|
{{if gt .ReleasesNum 0}}
|
|
<h4 class="ui top attached header">
|
|
<div class="five wide column df ac">
|
|
{{svg "octicon-tag" 16 "mr-2"}}{{.i18n.Tr "repo.release.tags"}}
|
|
</div>
|
|
</h4>
|
|
<div class="ui attached table segment">
|
|
<table class="ui very basic striped fixed table single line" id="tags-table">
|
|
<thead></thead>
|
|
<tbody class="tag-list">
|
|
{{range $idx, $release := .Releases}}
|
|
<tr>
|
|
<td class="tag">
|
|
<h3 class="release-tag-name mb-3">
|
|
<a class="df ac" href="{{$.RepoLink}}/src/tag/{{.TagName | PathEscapeSegments}}" rel="nofollow">{{.TagName}}</a>
|
|
</h3>
|
|
<div class="download df ac">
|
|
{{if $.Permission.CanRead $.UnitTypeCode}}
|
|
<a class="mr-3 mono" href="{{$.RepoLink}}/src/commit/{{.Sha1}}" rel="nofollow">{{svg "octicon-git-commit" 16 "mr-2"}}{{ShortSha .Sha1}}</a>
|
|
<a class="archive-link mr-3" data-url="{{$.RepoLink}}/archive/{{.TagName | PathEscapeSegments}}.zip" rel="nofollow">{{svg "octicon-file-zip" 16 "mr-2"}}ZIP</a>
|
|
<a class="archive-link mr-3" data-url="{{$.RepoLink}}/archive/{{.TagName | PathEscapeSegments}}.tar.gz">{{svg "octicon-file-zip" 16 "mr-2"}}TAR.GZ</a>
|
|
{{if (and $.CanCreateRelease $release.IsTag)}}
|
|
<a class="mr-3" href="{{$.RepoLink}}/releases/new?tag={{.TagName | PathEscapeSegments}}">{{svg "octicon-tag" 16 "mr-2"}}{{$.i18n.Tr "repo.release.new_release"}}</a>
|
|
{{end}}
|
|
{{if (and ($.Permission.CanWrite $.UnitTypeCode) $release.IsTag)}}
|
|
<a class="ui red delete-button mr-3" data-url="{{$.RepoLink}}/tags/delete" data-id="{{.ID}}">
|
|
{{svg "octicon-trash" 16 "mr-2"}}{{$.i18n.Tr "repo.release.delete_tag"}}
|
|
</a>
|
|
{{end}}
|
|
{{if (not $release.IsTag)}}
|
|
<a class="mr-3" href="{{$.RepoLink}}/releases/tag/{{.TagName | PathEscapeSegments}}">{{svg "octicon-tag" 16 "mr-2"}}{{$.i18n.Tr "repo.release.detail"}}</a>
|
|
{{end}}
|
|
{{end}}
|
|
</div>
|
|
</td>
|
|
</tr>
|
|
{{end}}
|
|
</tbody>
|
|
</table>
|
|
</div>
|
|
{{end}}
|
|
{{else}}
|
|
<ul id="release-list">
|
|
{{range $idx, $release := .Releases}}
|
|
<li class="ui grid">
|
|
<div class="ui four wide column meta mt-2">
|
|
{{if .IsTag}}
|
|
{{if .CreatedUnix}}<span class="time">{{TimeSinceUnix .CreatedUnix $.Lang}}</span>{{end}}
|
|
{{else}}
|
|
{{if .IsDraft}}
|
|
<span class="ui yellow label">{{$.i18n.Tr "repo.release.draft"}}</span>
|
|
{{else if .IsPrerelease}}
|
|
<span class="ui orange label">{{$.i18n.Tr "repo.release.prerelease"}}</span>
|
|
{{else}}
|
|
<span class="ui green label">{{$.i18n.Tr "repo.release.stable"}}</span>
|
|
{{end}}
|
|
<span class="tag text blue">
|
|
<a class="df ac je" href="{{if .IsDraft}}#{{else}}{{$.RepoLink}}/src/tag/{{.TagName | PathEscapeSegments}}{{end}}" rel="nofollow">{{svg "octicon-tag" 16 "mr-2"}}{{.TagName}}</a>
|
|
</span>
|
|
{{if not .IsDraft}}
|
|
<span class="commit">
|
|
<a class="mono" href="{{$.RepoLink}}/src/commit/{{.Sha1}}" rel="nofollow">{{svg "octicon-git-commit" 16 "mr-2"}}{{ShortSha .Sha1}}</a>
|
|
</span>
|
|
{{end}}
|
|
{{if .Sha1 }}
|
|
{{template "repo/branch_dropdown" dict "root" $ "release" .}}
|
|
{{end}}
|
|
{{end}}
|
|
</div>
|
|
<div class="ui twelve wide column detail">
|
|
{{if .IsTag}}
|
|
<h4>
|
|
<a href="{{$.RepoLink}}/src/tag/{{.TagName | PathEscapeSegments}}" rel="nofollow">{{svg "octicon-tag" 16 "mr-2"}}{{.TagName}}</a>
|
|
</h4>
|
|
<p class="text grey">
|
|
{{ if gt .Publisher.ID 0 }}
|
|
<span class="author">
|
|
{{avatar .Publisher 20}}
|
|
<a href="{{.Publisher.HomeLink}}">{{.Publisher.Name}}</a>
|
|
</span>
|
|
{{ end }}
|
|
<span class="ahead"><a href="{{$.RepoLink}}/compare/{{.TagName | PathEscapeSegments}}...{{.Target | PathEscapeSegments}}">{{$.i18n.Tr "repo.release.ahead.commits" .NumCommitsBehind | Str2html}}</a> {{$.i18n.Tr "repo.release.ahead.target" $.DefaultBranch}}</span>
|
|
</p>
|
|
<div class="download">
|
|
{{if $.Permission.CanRead $.UnitTypeCode}}
|
|
<a class="mono" href="{{$.RepoLink}}/src/commit/{{.Sha1}}" rel="nofollow">{{svg "octicon-git-commit" 16 "mr-2"}}{{ShortSha .Sha1}}</a>
|
|
<a class="archive-link" data-url="{{$.RepoLink}}/archive/{{.TagName | PathEscapeSegments}}.zip" rel="nofollow">{{svg "octicon-file-zip"}} ZIP</a>
|
|
<a class="archive-link" data-url="{{$.RepoLink}}/archive/{{.TagName | PathEscapeSegments}}.tar.gz">{{svg "octicon-file-zip"}} TAR.GZ</a>
|
|
{{end}}
|
|
</div>
|
|
{{else}}
|
|
<h4 class="release-list-title df ac">
|
|
<a href="{{$.RepoLink}}/releases/tag/{{.TagName | PathEscapeSegments}}">{{.Title}}</a>
|
|
{{if $.CanCreateRelease}}
|
|
<small class="ml-2">
|
|
(<a href="{{$.RepoLink}}/releases/edit/{{.TagName | PathEscapeSegments}}" rel="nofollow">{{$.i18n.Tr "repo.release.edit"}}</a>)
|
|
</small>
|
|
{{end}}
|
|
</h4>
|
|
<p class="text grey">
|
|
<span class="author">
|
|
{{if .OriginalAuthor}}
|
|
{{svg "octicon-mark-github" 16 "mr-2"}}{{.OriginalAuthor}}
|
|
{{else if .Publisher}}
|
|
{{avatar .Publisher 20}}
|
|
<a href="{{.Publisher.HomeLink}}">{{.Publisher.GetDisplayName}}</a>
|
|
{{else}}
|
|
Ghost
|
|
{{end}}
|
|
</span>
|
|
<span class="released">
|
|
{{$.i18n.Tr "repo.released_this"}}
|
|
</span>
|
|
{{if .CreatedUnix}}
|
|
<span class="time">{{TimeSinceUnix .CreatedUnix $.Lang}}</span>
|
|
{{end}}
|
|
{{if not .IsDraft}}
|
|
| <span class="ahead"><a href="{{$.RepoLink}}/compare/{{.TagName | PathEscapeSegments}}...{{.Target | PathEscapeSegments}}">{{$.i18n.Tr "repo.release.ahead.commits" .NumCommitsBehind | Str2html}}</a> {{$.i18n.Tr "repo.release.ahead.target" .Target}}</span>
|
|
{{end}}
|
|
</p>
|
|
<div class="markup desc">
|
|
{{Str2html .Note}}
|
|
</div>
|
|
<details class="download border-secondary-top mt-4 pt-4" {{if eq $idx 0}}open{{end}}>
|
|
<summary class="mb-4">
|
|
{{$.i18n.Tr "repo.release.downloads"}}
|
|
</summary>
|
|
<ul class="list">
|
|
{{if and (not .IsDraft) ($.Permission.CanRead $.UnitTypeCode)}}
|
|
<li>
|
|
<a class="archive-link" data-url="{{$.RepoLink}}/archive/{{.TagName | PathEscapeSegments}}.zip" rel="nofollow"><strong>{{svg "octicon-file-zip" 16 "mr-2"}}{{$.i18n.Tr "repo.release.source_code"}} (ZIP)</strong></a>
|
|
</li>
|
|
<li>
|
|
<a class="archive-link" data-url="{{$.RepoLink}}/archive/{{.TagName | PathEscapeSegments}}.tar.gz"><strong>{{svg "octicon-file-zip" 16 "mr-2"}}{{$.i18n.Tr "repo.release.source_code"}} (TAR.GZ)</strong></a>
|
|
</li>
|
|
{{end}}
|
|
{{if .Attachments}}
|
|
{{range .Attachments}}
|
|
<li>
|
|
<span class="ui text middle aligned right">
|
|
<span class="ui text grey">{{.Size | FileSize}}</span>
|
|
<span class="poping up" data-content="{{$.i18n.Tr "repo.release.download_count" (.DownloadCount | PrettyNumber)}}">
|
|
{{svg "octicon-info"}}
|
|
</span>
|
|
</span>
|
|
<a target="_blank" rel="noopener noreferrer" href="{{.DownloadURL}}">
|
|
<strong><span class="ui image" title='{{.Name}}'>{{svg "octicon-package" 16 "mr-2"}}</span>{{.Name}}</strong>
|
|
</a>
|
|
</li>
|
|
{{end}}
|
|
{{end}}
|
|
</ul>
|
|
</details>
|
|
{{end}}
|
|
<span class="dot"> </span>
|
|
</div>
|
|
</li>
|
|
{{end}}
|
|
</ul>
|
|
{{end}}
|
|
{{template "base/paginate" .}}
|
|
</div>
|
|
</div>
|
|
|
|
{{if (and ($.Permission.CanWrite $.UnitTypeCode) .PageIsTagList)}}
|
|
<div class="ui small basic delete modal">
|
|
<div class="ui header">
|
|
{{svg "octicon-trash" 16 "mr-2"}}
|
|
{{.i18n.Tr "repo.release.delete_tag"}}
|
|
</div>
|
|
<div class="content">
|
|
<p>{{.i18n.Tr "repo.release.deletion_tag_desc"}}</p>
|
|
</div>
|
|
{{template "base/delete_modal_actions" .}}
|
|
</div>
|
|
{{end}}
|
|
|
|
{{template "base/footer" .}}
|