mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-10 04:05:42 +01:00
4de909747b
Some checks are pending
/ release (push) Waiting to run
testing / test-remote-cacher (map[image:redis:7.2 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:registry.redict.io/redict:7.3.0-scratch port:6379]) (push) Blocked by required conditions
testing / test-mysql (push) Blocked by required conditions
testing / test-pgsql (push) Blocked by required conditions
testing / backend-checks (push) Waiting to run
testing / frontend-checks (push) Waiting to run
testing / test-unit (push) Blocked by required conditions
testing / test-remote-cacher (map[image:docker.io/valkey/valkey:7.2.5-alpine3.19 port:6379]) (push) Blocked by required conditions
testing / test-remote-cacher (map[image:ghcr.io/microsoft/garnet-alpine:1.0.14 port:6379]) (push) Blocked by required conditions
testing / test-sqlite (push) Blocked by required conditions
testing / security-check (push) Blocked by required conditions
go-require lint is ignored for now Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4535 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: TheFox0x7 <thefox0x7@gmail.com> Co-committed-by: TheFox0x7 <thefox0x7@gmail.com>
125 lines
2.4 KiB
Go
125 lines
2.4 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package codeformat
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestFormatImportsSimple(t *testing.T) {
|
|
formatted, err := formatGoImports([]byte(`
|
|
package codeformat
|
|
|
|
import (
|
|
"github.com/stretchr/testify/assert"
|
|
"testing"
|
|
)
|
|
`))
|
|
|
|
expected := `
|
|
package codeformat
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
`
|
|
|
|
require.NoError(t, err)
|
|
assert.Equal(t, expected, string(formatted))
|
|
}
|
|
|
|
func TestFormatImportsGroup(t *testing.T) {
|
|
// gofmt/goimports won't group the packages, for example, they produce such code:
|
|
// "bytes"
|
|
// "image"
|
|
// (a blank line)
|
|
// "fmt"
|
|
// "image/color/palette"
|
|
// our formatter does better, and these packages are grouped into one.
|
|
|
|
formatted, err := formatGoImports([]byte(`
|
|
package test
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"image"
|
|
"image/color"
|
|
|
|
_ "image/gif" // for processing gif images
|
|
_ "image/jpeg" // for processing jpeg images
|
|
_ "image/png" // for processing png images
|
|
|
|
"code.gitea.io/other/package"
|
|
|
|
"code.gitea.io/gitea/modules/setting"
|
|
"code.gitea.io/gitea/modules/util"
|
|
|
|
"xorm.io/the/package"
|
|
|
|
"github.com/issue9/identicon"
|
|
"github.com/nfnt/resize"
|
|
"github.com/oliamb/cutter"
|
|
)
|
|
`))
|
|
|
|
expected := `
|
|
package test
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"image"
|
|
"image/color"
|
|
|
|
_ "image/gif" // for processing gif images
|
|
_ "image/jpeg" // for processing jpeg images
|
|
_ "image/png" // for processing png images
|
|
|
|
"code.gitea.io/gitea/modules/setting"
|
|
"code.gitea.io/gitea/modules/util"
|
|
|
|
"code.gitea.io/other/package"
|
|
"github.com/issue9/identicon"
|
|
"github.com/nfnt/resize"
|
|
"github.com/oliamb/cutter"
|
|
"xorm.io/the/package"
|
|
)
|
|
`
|
|
|
|
require.NoError(t, err)
|
|
assert.Equal(t, expected, string(formatted))
|
|
}
|
|
|
|
func TestFormatImportsInvalidComment(t *testing.T) {
|
|
// why we shouldn't write comments between imports: it breaks the grouping of imports
|
|
// for example:
|
|
// "pkg1"
|
|
// "pkg2"
|
|
// // a comment
|
|
// "pkgA"
|
|
// "pkgB"
|
|
// the comment splits the packages into two groups, pkg1/2 are sorted separately, pkgA/B are sorted separately
|
|
// we don't want such code, so the code should be:
|
|
// "pkg1"
|
|
// "pkg2"
|
|
// "pkgA" // a comment
|
|
// "pkgB"
|
|
|
|
_, err := formatGoImports([]byte(`
|
|
package test
|
|
|
|
import (
|
|
"image/jpeg"
|
|
// for processing gif images
|
|
"image/gif"
|
|
)
|
|
`))
|
|
require.ErrorIs(t, err, errInvalidCommentBetweenImports)
|
|
}
|